Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for python 3.8 #1042

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Nov 27, 2024

Python 3.8 is now at end-of-life. We intend that FLORIS support only active versions of python. FLORIS v4.2 is the last minor version of FLORIS that supports version 3.8.

This pull request sets the required version of python at 3.9, and updates the testing matrices (#1019) to reflect that 3.8 is no longer supported. The testing matrix is now

workflow 3.8 3.9 3.10 3.11 3.12 3.13
check-working-examples ✔️ ✔️ ✔️ ✔️ ✔️
continuous-integration-workflow ✔️ ✔️ ✔️ ✔️ ✔️
deploy-pages ✔️
quality-metrics-workflow ✔️

Comment on lines -24 to +28
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Collaborator Author

@misi9170 misi9170 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulf81 @rafmudaf I've updated the classifiers list to all versions of python in the testing matrix, based on this definition.

@paulf81
Copy link
Collaborator

paulf81 commented Nov 27, 2024

This looks great @misi9170 !

@paulf81 paulf81 self-requested a review November 27, 2024 22:53
@misi9170 misi9170 requested a review from rafmudaf December 2, 2024 16:55
Copy link
Collaborator

@rafmudaf rafmudaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @misi9170. We also need to remember to update the conda-forge recipe to drop v3.8

@misi9170 misi9170 merged commit 7a7a829 into NREL:develop Dec 2, 2024
11 checks passed
@misi9170 misi9170 deleted the ehmt/remove-python38 branch December 2, 2024 19:29
@misi9170
Copy link
Collaborator Author

misi9170 commented Dec 2, 2024

Warnings were added to documentation in #1041, released in v4.2.1

@misi9170 misi9170 mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants